differentiate between failing and missing actions in error message #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legobeat
force-pushed
the
fix-log-failed-action
branch
from
fe8e838 to
9be615d
Compare
pwntester
approved these changes
Nov 4, 2024
|
Thanks for the PRs @legobeat |
|
And thanks to you! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
If an error is thrown during an action, an error is logged with the message
Incorrect action: $action. This is the same error message as for actually missing commands.This is confusing and adds friction for debugging.
Does this pull request fix one issue?
Describe how you did it
Differentiate between missing and failing actions and log them differently.
Describe how to verify it
Special notes for reviews
Checklist